Use a constant amount of memory for error slices and add error abstraction #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vegarsti
changed the title
vegarsti
force-pushed
the
cap-errors
branch
2 times, most recently
from
6bb20b9 to
94af396
Compare
vegarsti
changed the title
vegarsti
force-pushed
the
cap-errors
branch
2 times, most recently
from
49ef4d8 to
21299a0
Compare
|
@adammilnesmith Is this something like what you were envisioning? Maybe this became a bit of scope creep 🤔 |
vegarsti
commented
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Info struct in the Ingester a bit so that we have an inner Errors struct for keeping track of errors. We add a method for resetting at, for observing errors, and for transforming to progress reports. We make sure that the error slices do not grow unbounded, but we keep track of the total error counts as well.